https://work.fuss.bz.it/https://work.fuss.bz.it/favicon.ico?15861920342016-06-28T08:42:06ZFUSS at workPyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1842016-06-28T08:42:06ZMarco Marinello
<ul><li><strong>Status</strong> changed from <i>Nuovo</i> to <i>In elaborazione</i></li><li><strong>Assignee</strong> changed from <i>Marco Marinello</i> to <i>Christopher R. Gabriel</i></li></ul><p>Risolto nel commit cd3688e0</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1892016-06-28T09:03:37ZChristopher R. Gabrielcgabriel@truelite.it
<ul><li><strong>Status</strong> changed from <i>In elaborazione</i> to <i>Commenti</i></li><li><strong>Assignee</strong> changed from <i>Christopher R. Gabriel</i> to <i>Marco Marinello</i></li></ul><p>Vedo che il commit risolve solo l'esempio in questione, ma tutto il resto del codice non e' stato sistemato.</p>
<p>Questi gli errori/problemi rilevati:</p>
<pre>
./fabfile.py:6:1: E302 expected 2 blank lines, found 1
./fabfile.py:17:1: W293 blank line contains whitespace
./fabfile.py:17:1: W391 blank line at end of file
./hearings/admin.py:9:1: E303 too many blank lines (3)
./hearings/admin.py:20:1: E302 expected 2 blank lines, found 1
./hearings/admin.py:26:30: E231 missing whitespace after ','
./hearings/admin.py:26:36: E231 missing whitespace after ','
./hearings/admin.py:26:44: E231 missing whitespace after ','
./hearings/admin.py:26:50: E231 missing whitespace after ','
./hearings/admin.py:30:1: E302 expected 2 blank lines, found 1
./hearings/admin.py:39:1: E302 expected 2 blank lines, found 1
./hearings/forms.py:14:80: E501 line too long (106 > 79 characters)
./hearings/forms.py:40:9: E265 block comment should start with '# '
./hearings/models.py:26:1: E302 expected 2 blank lines, found 1
./hearings/models.py:27:80: E501 line too long (83 > 79 characters)
./hearings/models.py:29:80: E501 line too long (99 > 79 characters)
./hearings/models.py:31:80: E501 line too long (88 > 79 characters)
./hearings/models.py:34:80: E501 line too long (92 > 79 characters)
./hearings/models.py:54:1: W293 blank line contains whitespace
./hearings/models.py:56:80: E501 line too long (86 > 79 characters)
./hearings/models.py:65:5: E301 expected 1 blank line, found 0
./hearings/models.py:69:1: E302 expected 2 blank lines, found 1
./hearings/models.py:70:80: E501 line too long (82 > 79 characters)
./hearings/models.py:72:80: E501 line too long (97 > 79 characters)
./hearings/models.py:74:5: E301 expected 1 blank line, found 0
./hearings/models.py:78:1: W293 blank line contains whitespace
./hearings/models.py:81:80: E501 line too long (97 > 79 characters)
./hearings/models.py:87:80: E501 line too long (97 > 79 characters)
./hearings/models.py:100:80: E501 line too long (89 > 79 characters)
./hearings/models.py:137:1: W293 blank line contains whitespace
./hearings/models.py:139:1: W293 blank line contains whitespace
./hearings/models.py:140:1: E302 expected 2 blank lines, found 1
./hearings/models.py:147:80: E501 line too long (92 > 79 characters)
./hearings/models.py:149:80: E501 line too long (89 > 79 characters)
./hearings/models.py:151:80: E501 line too long (91 > 79 characters)
./hearings/models.py:160:1: W293 blank line contains whitespace
./hearings/models.py:175:1: W293 blank line contains whitespace
./hearings/models.py:176:5: E303 too many blank lines (2)
./hearings/models.py:193:5: E303 too many blank lines (2)
./hearings/models.py:229:80: E501 line too long (81 > 79 characters)
./hearings/models.py:232:1: W293 blank line contains whitespace
./hearings/models.py:234:5: E303 too many blank lines (2)
./hearings/models.py:253:5: E303 too many blank lines (2)
./hearings/models.py:261:1: E302 expected 2 blank lines, found 1
./hearings/models.py:268:1: E302 expected 2 blank lines, found 1
./hearings/models.py:271:1: W391 blank line at end of file
./hearings/urls.py:17:1: W293 blank line contains whitespace
./hearings/views.py:20:33: E225 missing whitespace around operator
./hearings/views.py:20:80: E501 line too long (86 > 79 characters)
./hearings/views.py:27:1: E302 expected 2 blank lines, found 1
./hearings/views.py:39:80: E501 line too long (94 > 79 characters)
./hearings/views.py:41:80: E501 line too long (108 > 79 characters)
./hearings/views.py:42:80: E501 line too long (117 > 79 characters)
./hearings/views.py:52:80: E501 line too long (93 > 79 characters)
./hearings/views.py:58:80: E501 line too long (116 > 79 characters)
./hearings/views.py:76:80: E501 line too long (94 > 79 characters)
./hearings/views.py:82:80: E501 line too long (89 > 79 characters)
./hearings/views.py:120:80: E501 line too long (94 > 79 characters)
./hearings/views.py:144:80: E501 line too long (99 > 79 characters)
./hearings/views.py:156:80: E501 line too long (94 > 79 characters)
./hearings/views.py:161:80: E501 line too long (87 > 79 characters)
./hearings/views.py:175:80: E501 line too long (93 > 79 characters)
./hearings/views.py:192:80: E501 line too long (86 > 79 characters)
./hearings/views.py:194:1: W293 blank line contains whitespace
./hearings/views.py:196:80: E501 line too long (107 > 79 characters)
./hearings/views.py:207:80: E501 line too long (93 > 79 characters)
./hearings/views.py:213:80: E501 line too long (96 > 79 characters)
./hearings/views.py:227:80: E501 line too long (93 > 79 characters)
./hearings/views.py:232:80: E501 line too long (85 > 79 characters)
./hearings/migrations/0001_initial.py:22:80: E501 line too long (114 > 79 characters)
./hearings/migrations/0001_initial.py:32:80: E501 line too long (114 > 79 characters)
./hearings/migrations/0001_initial.py:36:80: E501 line too long (85 > 79 characters)
./hearings/migrations/0001_initial.py:37:80: E501 line too long (150 > 79 characters)
./hearings/migrations/0001_initial.py:47:80: E501 line too long (114 > 79 characters)
./hearings/migrations/0001_initial.py:53:80: E501 line too long (114 > 79 characters)
./hearings/migrations/0001_initial.py:64:80: E501 line too long (114 > 79 characters)
./hearings/migrations/0001_initial.py:66:80: E501 line too long (149 > 79 characters)
./hearings/migrations/0001_initial.py:67:80: E501 line too long (145 > 79 characters)
./hearings/migrations/0001_initial.py:73:80: E501 line too long (132 > 79 characters)
./hearings/migrations/0001_initial.py:78:80: E501 line too long (136 > 79 characters)
./hearings/migrations/0001_initial.py:83:80: E501 line too long (142 > 79 characters)
./hearings/migrations/0001_initial.py:88:80: E501 line too long (144 > 79 characters)
./hearings/migrations/0001_initial.py:93:80: E501 line too long (138 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:19:80: E501 line too long (146 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:23:80: E501 line too long (130 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:27:80: E501 line too long (84 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:31:80: E501 line too long (103 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:35:80: E501 line too long (82 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:40:80: E501 line too long (168 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:45:80: E501 line too long (169 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:50:80: E501 line too long (162 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:75:80: E501 line too long (164 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:80:80: E501 line too long (156 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:85:80: E501 line too long (160 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:90:80: E501 line too long (85 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:95:80: E501 line too long (157 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:100:80: E501 line too long (87 > 79 characters)
./hearings/migrations/0002_auto_20160619_2131.py:105:80: E501 line too long (161 > 79 characters)
./pyhearing/context_processors.py:3:1: E302 expected 2 blank lines, found 1
./pyhearing/context_processors.py:6:1: W293 blank line contains whitespace
./pyhearing/context_processors.py:6:1: W391 blank line at end of file
./pyhearing/settings.py:100:15: E231 missing whitespace after ':'
./pyhearing/settings.py:100:80: E501 line too long (90 > 79 characters)
./pyhearing/settings.py:103:80: E501 line too long (81 > 79 characters)
./pyhearing/settings.py:106:80: E501 line too long (82 > 79 characters)
./pyhearing/settings.py:109:80: E501 line too long (83 > 79 characters)
./pyhearing/urls.py:33:1: E122 continuation line missing indentation or outdented
./pyhearing/urls.py:50:31: E203 whitespace before ':'
./pyhearing/urls.py:61:31: E203 whitespace before ':'
./pyhearing/urls.py:62:9: E128 continuation line under-indented for visual indent
./pyhearing/views.py:13:1: E302 expected 2 blank lines, found 1
./pyhearing/views.py:23:51: E225 missing whitespace around operator
./pyhearing/views.py:32:17: E128 continuation line under-indented for visual indent
./pyhearing/views.py:32:80: E501 line too long (109 > 79 characters)
./pyhearing/views.py:61:1: E302 expected 2 blank lines, found 1
./pyhearing/views.py:94:80: E501 line too long (134 > 79 characters)
./pyhearing/views.py:101:80: E501 line too long (86 > 79 characters)
./pyhearing/management/commands/import_csv_parent.py:9:1: E302 expected 2 blank lines, found 0
./pyhearing/management/commands/import_csv_parent.py:25:9: E301 expected 1 blank line, found 0
./pyhearing/management/commands/import_csv_parent.py:31:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_parent.py:36:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:9:1: E302 expected 2 blank lines, found 0
./pyhearing/management/commands/import_csv_teacher.py:25:9: E301 expected 1 blank line, found 0
./pyhearing/management/commands/import_csv_teacher.py:31:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:36:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:54:43: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/import_csv_teacher.py:54:45: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/import_csv_teacher.py:56:1: W293 blank line contains whitespace
./pyhearing/management/commands/reminders.py:8:1: E302 expected 2 blank lines, found 1
./pyhearing/management/commands/reminders.py:15:1: W293 blank line contains whitespace
./pyhearing/management/commands/reminders.py:17:9: E303 too many blank lines (2)
./pyhearing/management/commands/reminders.py:17:68: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/reminders.py:17:70: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/reminders.py:28:1: W293 blank line contains whitespace
./pyhearing/templatetags/pyhearingtags.py:9:1: E302 expected 2 blank lines, found 1
</pre> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1942016-06-28T10:07:54ZMarco Marinello
<ul><li><strong>Assignee</strong> changed from <i>Marco Marinello</i> to <i>Christopher R. Gabriel</i></li></ul><p>Vedi commit ad0d2420</p>
<p>Tra i file indicati ce ne sono alcuni che non avevo toccato (come fabfile, context_processor) e alcuni non li ho corretti (come la management console e le migrations). Rimangono alcuni "errori" che ritengo non siano fixabili.</p>
<pre>
./pyhearing/settings.py:100:80: E501 line too long (91 > 79 characters)
./pyhearing/settings.py:103:80: E501 line too long (81 > 79 characters)
./pyhearing/settings.py:106:80: E501 line too long (82 > 79 characters)
./pyhearing/settings.py:109:80: E501 line too long (83 > 79 characters)
./pyhearing/views.py:39:80: E501 line too long (109 > 79 characters)
</pre> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1952016-06-28T10:11:23ZChristopher R. Gabrielcgabriel@truelite.it
<ul></ul><p>Ottimo, ne rimango ancora diversi pero' dopo il pull, anche per file che non hai toccato, per fare un porting ottimale.</p>
<pre>
./hearings/forms.py:16:13: E123 closing bracket does not match indentation of opening bracket's line
./hearings/forms.py:42:9: E123 closing bracket does not match indentation of opening bracket's line
./hearings/models.py:177:13: E123 closing bracket does not match indentation of opening bracket's line
./hearings/models.py:206:13: E123 closing bracket does not match indentation of opening bracket's line
./hearings/models.py:227:13: E123 closing bracket does not match indentation of opening bracket's line
./hearings/models.py:265:13: E123 closing bracket does not match indentation of opening bracket's line
./hearings/views.py:25:9: E123 closing bracket does not match indentation of opening bracket's line
./pyhearing/views.py:28:35: E123 closing bracket does not match indentation of opening bracket's line
./pyhearing/views.py:108:21: E123 closing bracket does not match indentation of opening bracket's line
./pyhearing/management/commands/import_csv_parent.py:9:1: E302 expected 2 blank lines, found 0
./pyhearing/management/commands/import_csv_parent.py:25:9: E301 expected 1 blank line, found 0
./pyhearing/management/commands/import_csv_parent.py:31:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_parent.py:36:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:9:1: E302 expected 2 blank lines, found 0
./pyhearing/management/commands/import_csv_teacher.py:25:9: E301 expected 1 blank line, found 0
./pyhearing/management/commands/import_csv_teacher.py:31:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:36:1: W293 blank line contains whitespace
./pyhearing/management/commands/import_csv_teacher.py:54:43: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/import_csv_teacher.py:54:45: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/import_csv_teacher.py:56:1: W293 blank line contains whitespace
./pyhearing/management/commands/reminders.py:8:1: E302 expected 2 blank lines, found 1
./pyhearing/management/commands/reminders.py:15:1: W293 blank line contains whitespace
./pyhearing/management/commands/reminders.py:17:9: E303 too many blank lines (2)
./pyhearing/management/commands/reminders.py:17:68: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/reminders.py:17:70: E251 unexpected spaces around keyword / parameter equals
./pyhearing/management/commands/reminders.py:28:1: W293 blank line contains whitespace
</pre> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1962016-06-28T10:11:29ZChristopher R. Gabrielcgabriel@truelite.it
<ul><li><strong>Assignee</strong> changed from <i>Christopher R. Gabriel</i> to <i>Marco Marinello</i></li></ul> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=1992016-06-28T10:22:14ZMarco Marinello
<ul><li><strong>Assignee</strong> changed from <i>Marco Marinello</i> to <i>Christopher R. Gabriel</i></li></ul><p>Il mio pep8 non da alcun errore sul file forms.py .<br />Lo stesso sui models.py e views.py .<br />Il resto lo correggo.</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2012016-06-28T10:46:28ZChristopher R. Gabrielcgabriel@truelite.it
<ul><li><strong>Status</strong> changed from <i>Commenti</i> to <i>In elaborazione</i></li><li><strong>Assignee</strong> changed from <i>Christopher R. Gabriel</i> to <i>Marco Marinello</i></li></ul><p>Ok, riassegna a me solo se devo fare qualcosa.</p>
<p>Io uso pep8 1.5.7, escludendo solo E501.</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2032016-06-28T11:48:13ZMarco Marinello
<ul></ul><p>Management console sistemata d549ed56</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2202016-06-30T13:18:48ZMarco Marinello
<ul><li><strong>Assignee</strong> deleted (<del><i>Marco Marinello</i></del>)</li></ul> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2372016-07-04T11:02:01ZChristopher R. Gabrielcgabriel@truelite.it
<ul><li><strong>Assignee</strong> set to <i>Marco Marinello</i></li></ul><p>E' stato lasciato in elaborazione, ma togliendo l'assegnatario. Chi e' che lo sta elaborando?</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2392016-07-04T12:24:59ZMarco Marinello
<ul><li><strong>Status</strong> changed from <i>In elaborazione</i> to <i>Commenti</i></li><li><strong>Assignee</strong> deleted (<del><i>Marco Marinello</i></del>)</li><li><strong>Priority</strong> changed from <i>Normale</i> to <i>Bassa</i></li></ul><p>Io, al momento, no. Inoltre, esclusi i file migrations, non ho altre segnalazioni di errori da parte di pep8 (tutti gli errori considerati, versione 1.5.7)</p> PyHearing - Segnalazione #58: Fix per PEP8https://work.fuss.bz.it/issues/58?journal_id=2402016-07-04T12:26:55ZChristopher R. Gabrielcgabriel@truelite.it
<ul><li><strong>Status</strong> changed from <i>Commenti</i> to <i>Chiuso</i></li><li><strong>Resolution</strong> set to <i>fixed</i></li></ul><p>Ok, allora meglio se veniva assegnato con stato Commenti.</p>
<p>Se togli l'assegnatario, nessuno ci guarda poi... perche' non risulta in carico a nessuno.</p>
<p>Chiudo, rimangono due cose in views e settings, ma sorvoliamo.</p>